linux-kernel - Re: [PATCH] mmc: sdhci: change sdhci-pltfm into a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 5 Jun 2011 08:56:39 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Shawn Guo <shawn.guo@...aro.org>
Cc:	linux-mmc@...r.kernel.org, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, cbouatmailru@...il.com,
	cjb@...top.org, grant.likely@...retlab.ca, arnd@...db.de,
	sfr@...b.auug.org.au, patches@...aro.org,
	Shawn Guo <shawn.guo@...escale.com>
Subject: Re: [PATCH] mmc: sdhci: change sdhci-pltfm into a module

On Thu, Jun 02, 2011 at 10:57:50AM +0800, Shawn Guo wrote:
> From: Shawn Guo <shawn.guo@...escale.com>
> 
> There are a couple of problems left from the sdhci pltfm and OF
> consolidation changes.
> 
> * When building more than one sdhci-pltfm based drivers in the same
>   image, linker will give multiple definition error on the sdhci-pltfm
>   helper functions.  For example right now, building sdhci-of-esdhc
>   and sdhci-of-hlwd together is a valid combination from Kconfig view.
> 
> * With the current build method, there is error with building the
>   drivers as module, but module installation fails with modprobe.
> 
> The patch fixes above problems by changing sdhci-pltfm into a module.
> To avoid EXPORT_SYMBOL on so many big endian IO accessors, it moves
> these accessors into sdhci-pltfm.h as the 'static inline' functions.
> As a result, sdhci.h needs to be included in sdhci-pltfm.h, and in
> turn can be removed from individual drivers which already include
> sdhci-pltfm.h.
> 
> Signed-off-by: Shawn Guo <shawn.guo@...aro.org>

I am a bit confused how to review this patch and patch 1/4 from Shawn's
original series. As Chris does rebase his mmc-next anyway, does it make sense
to squash this into the old ones to prevent the broken inbetween state?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)