linux-kernel - Re: [PATCH] spi: reorganize drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinoEQf2a65KwQZOVK_4H9DSfqybjA@mail.gmail.com>
Date:	Sun, 5 Jun 2011 13:13:28 +0530
From:	Jassi Brar <jassisinghbrar@...il.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: reorganize drivers

On Sun, Jun 5, 2011 at 12:48 PM, Grant Likely <grant.likely@...retlab.ca> wrote:
> [repost: I had a typo on the spi-devel-general mailing list address]
>
> Sort the SPI makefile and enforce the naming convention spi_*.c for
> spi drivers.
>
> This change also rolls the contents of atmel_spi.h into the .c file
> since there is only one user of that particular include file.
>
> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
> ---
>  drivers/spi/Makefile            |   80 ++++++++-----------
>  drivers/spi/atmel_spi.h         |  167 ---------------------------------------
>  drivers/spi/spi_ath79.c         |    0
>  drivers/spi/spi_atmel.c         |  155 ++++++++++++++++++++++++++++++++++++
>  drivers/spi/spi_au1550.c        |    0
>  drivers/spi/spi_coldfire_qspi.c |    0
>  drivers/spi/spi_davinci.c       |    0
>  drivers/spi/spi_dw.c            |    2
>  drivers/spi/spi_dw.h            |    0
>  drivers/spi/spi_dw_mid.c        |    2
>  drivers/spi/spi_dw_mmio.c       |    2
>  drivers/spi/spi_dw_pci.c        |    2
>  drivers/spi/spi_ep93xx.c        |    0
>  drivers/spi/spi_mpc512x_psc.c   |    0
>  drivers/spi/spi_mpc52xx.c       |    0
>  drivers/spi/spi_mpc52xx_psc.c   |    0
>  drivers/spi/spi_omap2_mcspi.c   |    0
>  drivers/spi/spi_omap_100k.c     |    0
>  drivers/spi/spi_omap_uwire.c    |    0
>  drivers/spi/spi_orion.c         |    0
>  drivers/spi/spi_pl022.c         |    0
>  drivers/spi/spi_pxa2xx.c        |    0
>  drivers/spi/spi_pxa2xx_pci.c    |    0
>  drivers/spi/spi_ti_ssp.c        |    0
>  drivers/spi/spi_tle62x0.c       |    0
>  drivers/spi/spi_xilinx.c        |    0

Though the spi_ prefix seems redundant considering the files are in
'spi' directory.
Just a thought, no objection.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/