linux-kernel - Re: [PATCH] Unhide DEBUG_RODATA if EXPERT, even if DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110605093807.GB19927@elte.hu>
Date:	Sun, 5 Jun 2011 11:38:07 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Josh Triplett <josh@...htriplett.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Sam Ravnborg <sam@...nborg.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Unhide DEBUG_RODATA if EXPERT, even if DEBUG_KERNEL=n


* Josh Triplett <josh@...htriplett.org> wrote:

> --- a/arch/x86/Kconfig.debug
> +++ b/arch/x86/Kconfig.debug
> @@ -81,7 +81,7 @@ config X86_PTDUMP
>  config DEBUG_RODATA
>  	bool "Write protect kernel read-only data structures"
>  	default y
> -	depends on DEBUG_KERNEL
> +	depends on DEBUG_KERNEL || EXPERT

This is doing it the wrong way around. The right solution is what i 
wrote for verbose-debug: if we select DEBUG_KERNEL from EXPERT then 
you will avoid having to expand || EXPERT conditions into every 
default-enabled debug facility ...

My suggested solution will be a lot easier to maintain as well as 
under your scheme, because with your scheme we'd have to:

  - add || EXPERT every time a debug facility is enabled by default

  - remove || EXPERT every time a debug facility is switched to 
    off-by-default

If EXPERT selects DEBUG_KERNEL then we always get the right behavior, 
without polluting debug Kconfig's with EXPERT logic ...


Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/