linux-kernel - RE: [RFC][PATCH] powerpc: Use the #address-cells information to parsememory/reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AE90C24D6B3A694183C094C60CF0A2F6D8AD73@saturn3.aculab.com>
Date:	Mon, 6 Jun 2011 10:00:22 +0100
From:	"David Laight" <David.Laight@...LAB.COM>
To:	"Suzuki Poulose" <suzuki@...ibm.com>,
	"Simon Horman" <horms@...ge.net.au>
Cc:	"Sebastian Andrzej Siewior" <bigeasy@...utronix.de>,
	<kexec@...ts.infradead.org>, "lkml" <linux-kernel@...r.kernel.org>,
	"linux ppc dev" <linuxppc-dev@...ts.ozlabs.org>,
	"Vivek Goyal" <vgoyal@...hat.com>
Subject: RE: [RFC][PATCH] powerpc: Use the #address-cells information to parsememory/reg

> > Changed the add_usable_mem_property() to accept FILE* fp instead of
int fd,
> > as most of the other users of read_memory_region_limits() deals with
FILE*.
> >
> > Signed-off-by: Suzuki K. Poulose <suzuki@...ibm.com>
> 
> Could you please let me know your thoughts/comments about this patch ?

Is the change to use 'FILE *' actually progress?
I'd have thought that the randomly aligned read/lseek system calls
that this allows to happen are not desirable for anything that
isn't a true file.

I'd also suggest that the sizeof's should be applied to the
actual type of the variable being read/written, not arbitrarily
'long' or 'int', and this probably ought to be some fixed size type.

	David


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/