linux-kernel - Re: [PATCH RFC] fs: introduce a default_open for simple f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 06 Jun 2011 13:36:10 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	linux-fsdevel@...r.kernel.org, viro@...iv.linux.org.uk,
	matthew@....cx, dwmw2@...radead.org, robert.richter@....com,
	gregkh@...e.de, jmorris@...ei.org, npiggin@...nel.dk,
	ak@...ux.intel.com, dchinner@...hat.com
Subject: Re: [PATCH RFC] fs: introduce a default_open for simple f_op->open
 use

On Thu, 2011-06-02 at 15:04 -0700, H Hartley Sweeten wrote:
> There are many f_op->open implementations that simply do:
> 
> 	file->private_data = inode->i_private;
> 
> This introduces a new global symbol, default_open, that can be
> used instead of the private implementations.
> 
> This also removes a couple private implementations that share the
> same symbol name.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Alexander Viro <viro@...iv.linux.org.uk>
> Cc: Matthew Wilcox <matthew@....cx>
> Cc: Artem Bityutskiy <dedekind1@...il.com>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Robert Richter <robert.richter@....com>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Cc: James Morris <jmorris@...ei.org>
> Cc: Nick Piggin <npiggin@...nel.dk>
> Cc: Andi Kleen <ak@...ux.intel.com>
> Cc: Dave Chinner <dchinner@...hat.com>
> 
> ---
> 
> If this patch looks reasonable, I have some additional patches that
> convert all other similar f_op->open implemenations to use default_open
> tree wide.  The full diffstat looks like this:

Looks good to me, thanks.

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/