linux-kernel - Re: [PATCH] savage: remove unecessary if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110606125316.312fad32@absol.kitzblitz>
Date:	Mon, 6 Jun 2011 12:53:16 +0200
From:	Nicolas Kaiser <nikai@...ai.net>
To:	Dave Airlie <airlied@...ux.ie>
Cc:	Greg Dietsche <Gregory.Dietsche@....edu>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] savage: remove unecessary if statement

* Greg Dietsche <Gregory.Dietsche@....edu>:
> the code always returns ret regardless, so if(ret) check is unecessary.
/unecessary/unnecessary/

> 
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@....edu>
Reviewed-by: Nicolas Kaiser <nikai@...ai.net>

Best regards,
Nicolas Kaiser
> ---
>  drivers/gpu/drm/savage/savage_bci.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
> index bf5f83e..cb1ee4e 100644
> --- a/drivers/gpu/drm/savage/savage_bci.c
> +++ b/drivers/gpu/drm/savage/savage_bci.c
> @@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
>  	ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
>  			 _DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
>  			 &dev_priv->aperture);
> -	if (ret)
> -		return ret;
> -
>  	return ret;
>  }
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/