linux-kernel - Re: [PATCH v14 7/9] usb:gadget: Add SuperSpeed support to the Gadget Framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2011 14:14:27 +0300
From:	Felipe Balbi <balbi@...com>
To:	Tanya Brokhman <tlinder@...eaurora.org>
Cc:	balbi@...com, greg@...ah.com, linux-usb@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, ablay@...eaurora.org,
	'open list' <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v14 7/9] usb:gadget: Add SuperSpeed support to the Gadget
 Framework

On Fri, Jun 03, 2011 at 09:00:17PM +0300, Tanya Brokhman wrote:
> Hi Felipe,
> 
> > On Tue, May 31, 2011 at 04:18:27PM +0300, Tatyana Brokhman wrote:
> > > @@ -377,9 +425,10 @@ static int config_desc(struct usb_composite_dev
> > *cdev, unsigned w_value)
> > >  	u8				type = w_value >> 8;
> > >  	enum usb_device_speed		speed = USB_SPEED_UNKNOWN;
> > >
> > > -	if (gadget_is_dualspeed(gadget)) {
> > > -		int			hs = 0;
> > > -
> > > +	if (gadget->speed == USB_SPEED_SUPER)
> > 
> > if (gadget_is_superspeed(gadget)) ??
> I thought so too at first but then I decided that checking gadget->speed is
> better here because it's possible that gadget_is_superspeed() will return
> true but the actual speed will be for example HS. In that case we want to
> enter the  else of this if (else if (gadget_is_dualspeed()) {... })

ok, makes sense.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)