linux-kernel - Re: [PATCH] Disable CONFIG_CONSTRUCTORS when not needed by CONFIG_GCOV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 6 Jun 2011 15:11:01 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	Peter Oberparleiter <oberpar@...ux.vnet.ibm.com>
Cc:	Rusty Russell <rusty@...tcorp.com.au>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Sam Ravnborg <sam@...nborg.org>, Jeff Dike <jdike@...toit.com>,
	Andi Kleen <andi@...stfloor.org>,
	Huang Ying <ying.huang@...el.com>, Li Wei <W.Li@....COM>,
	Michael Ellerman <michaele@....ibm.com>,
	Ingo Molnar <mingo@...e.hu>,
	Heiko Carstens <heicars2@...ux.vnet.ibm.com>,
	Martin Schwidefsky <mschwid2@...ux.vnet.ibm.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Disable CONFIG_CONSTRUCTORS when not needed by
 CONFIG_GCOV_KERNEL

On Mon, Jun 06, 2011 at 12:56:33PM +0200, Peter Oberparleiter wrote:
> On 05.06.2011 10:21, Josh Triplett wrote:
> >CONFIG_CONSTRUCTORS controls support for running constructor functions
> >at kernel init time.  According to commit
> >b99b87f70c7785ab1e253c6220f4b0b57ce3a7f7, gcov (CONFIG_GCOV_KERNEL)
> >needs this.  However, CONFIG_CONSTRUCTORS currently defaults to y, with
> >no option to disable it, and CONFIG_GCOV_KERNEL depends on it.  Instead,
> >default it to n and have CONFIG_GCOV_KERNEL select it, so that the
> >normal case of CONFIG_GCOV_KERNEL=n will result in
> >CONFIG_CONSTRUCTORS=n.
> >
> >Observed in the short list of =y values in a minimal kernel
> >configuration.
> >
> >Signed-off-by: Josh Triplett<josh@...htriplett.org>
> >---
> 
> I tested this patch and GCOV profiling still works with it applied.
> To my knowledge, GCOV profiling is the only kernel mechanism using
> GCC's constructors and this may save some bytes.
> 
> Acked-by: Peter Oberparleiter <peter.oberparleiter@...ibm.com>

Excellent, thanks for testing and acking.

What tree should this patch go through?

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/