linux-kernel - Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110607103346.GU12242@legolas.emea.dhcp.ti.com>
Date:	Tue, 7 Jun 2011 13:33:49 +0300
From:	Felipe Balbi <balbi@...com>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Tanya Brokhman <tlinder@...eaurora.org>, balbi@...com,
	'Sarah Sharp' <sarah.a.sharp@...ux.intel.com>, greg@...ah.com,
	linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	ablay@...eaurora.org, 'open list' <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v12 7/8] usb: Adding SuperSpeed support to dummy_hcd

Hi,

On Wed, May 25, 2011 at 10:39:24AM -0400, Alan Stern wrote:
> This patch (as1468) changes the Kconfig definition for
> USB_GADGET_DUALSPEED.  This option is determined entirely by which
> device controller drivers are to be built, through Select statements;
> it does not need to be (and should not be) configurable by the user.
> 
> Also, the "default n" line is superfluous -- everything defaults to N.
> 
> Signed-off-by: Alan Stern <stern@...land.harvard.edu>

this patch makes a lot of sense. FWIW:

Acked-by: Felipe Balbi <balbi@...com>

> ---
> 
>  drivers/usb/gadget/Kconfig |    5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> Index: usb-2.6/drivers/usb/gadget/Kconfig
> ===================================================================
> --- usb-2.6.orig/drivers/usb/gadget/Kconfig
> +++ usb-2.6/drivers/usb/gadget/Kconfig
> @@ -597,13 +597,10 @@ config USB_DUMMY_HCD
>  
>  endchoice
>  
> +# Selected by UDC drivers that support high-speed operation.
>  config USB_GADGET_DUALSPEED
>  	bool
>  	depends on USB_GADGET
> -	default n
> -	help
> -	  Means that gadget drivers should include extra descriptors
> -	  and code to handle dual-speed controllers.
>  
>  #
>  # USB Gadget Drivers
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)