linux-kernel - Re: [PATCH -v3] vfs: make unlink() and rmdir() return ENOENT in preference to EROFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DEE32B4.509@msgid.tls.msk.ru>
Date:	Tue, 07 Jun 2011 18:16:20 +0400
From:	Michael Tokarev <mjt@....msk.ru>
To:	Theodore Ts'o <tytso@....edu>
CC:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	viro@...IV.linux.org.uk
Subject: Re: [PATCH -v3] vfs: make unlink() and rmdir() return ENOENT in preference
 to EROFS

07.06.2011 03:19, Theodore Ts'o wrote:
> If user space attempts to remove a non-existent file or directory, and
> the file system is mounted read-only, return ENOENT instead of EROFS.
> Either error code is arguably valid/correct, but ENOENT is a more
> specific error message.
> 
> Reported-by: Michael Tokarev <mjt@....msk.ru>
> Signed-off-by: "Theodore Ts'o" <tytso@....edu>

Thank you very much for this patch.  I had no chance to test it before,
now I've tested it and it works as expected - now both rm(1) and rmdir(1)
behave correctly, and git rm works too.

It's interesting to note that it's been this way for several years
(when the change occured?), and there has been no complains so far... ;)

Thanks!

/mjt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/