linux-kernel - Re: [PATCH v2] spi: reorganize drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTim927Ld28JmVfALscThef02XQJDWw@mail.gmail.com>
Date:	Mon, 6 Jun 2011 22:09:52 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Feng Tang <feng.tang@...el.com>
Cc:	Dirk Brandewie <dirk.brandewie@...il.com>,
	"spi-devel-general@...ts.sourceforge.net" 
	<spi-devel-general@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mike Frysinger <vapier.adi@...il.com>
Subject: Re: [PATCH v2] spi: reorganize drivers

On Mon, Jun 6, 2011 at 8:28 PM, Feng Tang <feng.tang@...el.com> wrote:
> On Tue, 7 Jun 2011 00:49:20 +0800
> Dirk Brandewie <dirk.brandewie@...il.com> wrote:
>
>> On 06/06/2011 09:38 AM, Grant Likely wrote:
>> > On Mon, Jun 6, 2011 at 10:31 AM, Mike
>> > Frysinger<vapier.adi@...il.com>  wrote:
>> >> On Mon, Jun 6, 2011 at 03:18, Grant Likely wrote:
>> >>> Sort the SPI makefile and enforce the naming convention spi_*.c
>> >>> for spi drivers.
>> >>
>> >> spi_topcliff_pch.c uses KBUILD_MODNAME with a few funcs, but
>> >> perhaps those are only for /proc/ status tracking ?  worth double
>> >> checking ...
>> >
>> > I just talked with Dirk Brandewie, who has a major rewrite to the
>> > topcliff spi driver.  I'll let him comment on whether or not
>> > changing KBUILD_MODNAME will cause any problems.
>> >
>>
>> My changes are to the designware driver :-) I will get my patches
>> re-based onto the spi-next branch and see if there any issues.
>
> If there is major rewrite to the dw_spi driver, please submit to this
> list, as it is used by many devices out there and needs a broad review

Hmmm.  Dirk, that could change things a bit.  From our conversation
today my understanding was that there weren't few if any users outside
of your circle.  If that isn't the case, then I'm going to be more
cautious about merging the rewrite.  Who are the people I should make
sure there is feedback from when the patch gets posted?

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/