linux-kernel - Re: [PATCH v2] spi: reorganize drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2011 00:48:49 -0400
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Feng Tang <feng.tang@...el.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Dirk Brandewie <dirk.brandewie@...il.com>,
	"spi-devel-general@...ts.sourceforge.net" 
	<spi-devel-general@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	alek.du@...el.com, alan@...ux.intel.com,
	jean-hugues.deschenes@...asic.com
Subject: Re: [PATCH v2] spi: reorganize drivers

On Tue, Jun 7, 2011 at 00:48, Feng Tang wrote:
> On Tue, 7 Jun 2011 12:09:52 +0800 Grant Likely wrote:
>> On Mon, Jun 6, 2011 at 8:28 PM, Feng Tang wrote:
>> > On Tue, 7 Jun 2011 00:49:20 +0800 Dirk Brandewie wrote:
>> >> My changes are to the designware driver :-) I will get my patches
>> >> re-based onto the spi-next branch and see if there any issues.
>> >
>> > If there is major rewrite to the dw_spi driver, please submit to
>> > this list, as it is used by many devices out there and needs a
>> > broad review
>>
>> Hmmm.  Dirk, that could change things a bit.  From our conversation
>> today my understanding was that there weren't few if any users outside
>> of your circle.  If that isn't the case, then I'm going to be more
>> cautious about merging the rewrite.  Who are the people I should make
>> sure there is feedback from when the patch gets posted?
>
> I don't know all the devices and users, but here is what I know: I've tested
> Max3110 spi-uart (in-tree), Option GTM501L high-speed 3G modem (out of tree),
> ektf1236 spi touch screen (out of tree). Alek Du (Cced) should have tested
> current dw_spi driver with some spi bluetooth device and modem device. Also
> the original author fordw_spi_mmio.c Jean-Hugues Deschense should have some
> experience too.

sounds like if there are multiple CPUs with this IP being added to
them, then perhaps a top level MAINTAINERS entry should be added so
interested parties can easily be located ... or listing in the
drivers/spi/Kconfig under the designware entry ... or a listing in the
designware spi driver itself ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/