linux-kernel - Re: [PATCH] x86: Fix sys_call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110608080346.GA11110@elte.hu>
Date:	Wed, 8 Jun 2011 10:03:46 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	x86@...nel.org
Subject: Re: [PATCH] x86: Fix sys_call_table type in asm/syscall.h


* Andi Kleen <andi@...stfloor.org> wrote:

> From: Andi Kleen <ak@...ux.intel.com>
> 
> Make the sys_call_table type defined in asm/syscall.h match
> the definition in syscall_64.c
> 
> Cc: x86@...nel.org
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>
> ---
>  arch/x86/include/asm/syscall.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/include/asm/syscall.h b/arch/x86/include/asm/syscall.h
> index c4a348f..32295b7 100644
> --- a/arch/x86/include/asm/syscall.h
> +++ b/arch/x86/include/asm/syscall.h
> @@ -16,7 +16,8 @@
>  #include <linux/sched.h>
>  #include <linux/err.h>
>  
> -extern const unsigned long sys_call_table[];
> +typedef void (*sys_call_ptr_t)(void);
> +extern const sys_call_ptr_t sys_call_table[];
>  
>  /*
>   * Only the low 32 bits of orig_ax are meaningful, so we return int.

There's an obvious problem with this patch, please fix it and resend.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/