linux-kernel - Re: [PATCH 1/3] x86: Readd asmregparm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110608081957.GA14966@elte.hu>
Date:	Wed, 8 Jun 2011 10:19:57 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, Andi Kleen <ak@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 1/3] x86: Readd asmregparm


* Andi Kleen <andi@...stfloor.org> wrote:

> From: Andi Kleen <ak@...ux.intel.com>
> 
> For a followon patchkit of mine I need to mark all functions
> that can be called from assembler. But on 32bit kernels some
> assembler functions are called with register arguments and others
> with stack arguments. asmlinkage forces stack arguments.
> 
> This patch readds the recently removed asmregparm to be able
> to mark assembler functions called with register arguments on 32bit.
> 
> Unlike the old code it's x86 only now to prevent it from
> leaking.
> 
> Cc: x86@...nel.org
> Signed-off-by: Andi Kleen <ak@...ux.intel.com>

That's a totally useless changelog (you are deliberately hiding 
information again) so the series is obviously not acceptable.
Please fix and resend.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/