linux-kernel - Re: [PATCH 1/3] x86: Readd asmregparm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2011 10:53:55 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andi Kleen <andi@...stfloor.org>, Andi Kleen <ak@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH 1/3] x86: Readd asmregparm

* Andi Kleen <andi@...stfloor.org> wrote:

> > That's a totally useless changelog (you are deliberately hiding 
> > information again) so the series is obviously not acceptable.
> > Please fix and resend.
> 
> I reread it and it seems complete to me. Please be more specific.
> 
> If you refer to the followon patchkit - it's not ready for posting 
> yet. [...]

You contradict yourself here - why do you claim that it's "complete" 
while you readily admit in the *next* sentence that the "followon 
patchkit" (with no specifics provided whatsoever) is "not ready for 
posting yet"?

You are not a newbie anymore, you know what the rules are for 
*everyone*: if it's not ready for posting yet then don't send a 
half-done series for inclusion, wasting everyone's time.

> [...] However I believe these changes are reasonable cleanups that 
> are useful on their own. That's why I posted them now.

Uhm, that's trivially untrue crazy talk and you should know it: the 
patches add code and typing complexity for no good stated reason 
whatsoever.

If we want the maintenance overhead of that then you better come up 
with your deliberately kept secret "project" and we'll be able to 
weigh whether the benefits overweigh the maintenance costs ...

In any case, i'd like to warn you that you are very close to me 
starting to ignore your mails summarily due to absymal low quality: 
in the past few months 70-80% of the cases your first patch 
submissions were trivially flawed, and in many cases you should have 
been well aware of the fact that they were trivially flawed. And 
that's not from a newbie but from a long-time kernel contributor!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/