linux-kernel - Re: [PATCH 6/10] drivers/char/hw_random/nomadik-rng.c: add missing clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 Jun 2011 21:01:15 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Matt Mackall <mpm@...enic.com>
Cc:	Julia Lawall <julia@...u.dk>, kernel-janitors@...r.kernel.org,
	Russell King <rmk+kernel@....linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/10] drivers/char/hw_random/nomadik-rng.c: add missing
	clk_put

On Wed, Jun 01, 2011 at 12:20:46PM -0500, Matt Mackall wrote:
> On Wed, 2011-06-01 at 19:10 +0200, Julia Lawall wrote:
> > From: Julia Lawall <julia@...u.dk>
> > 
> > Jump to the end of the function for the clk_disable and clk_put rather than
> > returning directly.
> > 
> > A simplified version of the semantic match that finds this problem is as
> > follows: (http://coccinelle.lip6.fr/)
> > 
> > // <smpl>
> > @r exists@
> > expression e1,e2;
> > statement S;
> > @@
> > 
> > e1 = clk_get@p1(...);
> > ... when != e1 = e2
> >     when != clk_put(e1)
> >     when any
> > if (...) { ... when != clk_put(e1)
> >                when != if (...) { ... clk_put(e1) ... }
> > * return@p3 ...;
> >  } else S
> > // </smpl>
> > 
> > Signed-off-by: Julia Lawall <julia@...u.dk>
> 
> This one also looks good to me.
> 
> Signed-off-by: Matt Mackall <mpm@...enic.com>

Both patches applied.  Thanks!
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/