linux-kernel - Re: [PATCH/RESEND v4 1/2] spi_topcliff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110608144426.GA8499@ponder.secretlab.ca>
Date:	Wed, 8 Jun 2011 08:44:26 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	spi-devel-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, qi.wang@...el.com,
	yong.y.wang@...el.com, joel.clark@...el.com,
	kok.howg.ewe@...el.com, toshiharu-linux@....okisemi.com
Subject: Re: [PATCH/RESEND v4 1/2] spi_topcliff_pch: support new device
 ML7213 IOH

On Wed, Jun 08, 2011 at 05:35:19PM +0900, Tomoya MORINAGA wrote:
> Hi Grant,
> 
> Why don't you give us your comment/opinion at all for our v4 patch ??
> We have been long waiting since 27-April.

Sorry about that Tomoya.  I got completely overloaded at the end of
April and all of May.  I ended up dropping a lot of patches on the
floor because of it.  I'm not purposefully ignoring you!

I'll look at them now.

g.

> 
> (2011/06/07 14:50), Tomoya MORINAGA wrote:
> > ***Modify Grant's comments.
> >     - Delete unrelated whitespace
> >     - Prevent device driver from accessing platform data
> >     - Add __devinit and __devexit
> >     - Save pdev->dev to pd_dev->dev.parent
> >     - Have own suspend/resume processing in platform_driver.
> >     - Care returned value in pch_spi_init
> >     - Change unregister order
> > 
> > Support ML7213 device of OKI SEMICONDUCTOR.
> > ML7213 is companion chip of Intel Atom E6xx series for IVI(In-Vehicle Infotainment).
> > ML7213 is compatible for Intel EG20T PCH.
> > 
> > Signed-off-by: Tomoya MORINAGA<tomoya-linux@....okisemi.com>
> > ---
> >   drivers/spi/Kconfig            |    5 +-
> >   drivers/spi/spi_topcliff_pch.c |  599 +++++++++++++++++++++-------------------
> >   2 files changed, 317 insertions(+), 287 deletions(-)
> > 
> -- 
> tomoya
> OKI SEMICONDUCTOR CO., LTD.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/