linux-kernel - [BUGFIX][PATCH] fix node hotplug zonelist build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20110608101506.60642149.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Wed, 8 Jun 2011 10:15:06 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	"linux-mm@...ck.org" <linux-mm@...ck.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Mel Gorman <mel@....ul.ie>, dave@...ux.vnet.ibm.com,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>
Subject: [BUGFIX][PATCH] fix node hotplug zonelist build


At memory hotplug, we reflesh zonelists when we online a page in a new zone.
It means that Node's zonelist is not initialized until pages are onlined. So,
for example, "nid" passed by MEM_GOING_ONLINE notifier will point to
NODE_DATA(nid) which has no zone fallback list. Moreover, if we hot-add
cpu-only nodes, alloc_pages() will do no fallback.

This patch makes zonelist when a new pgdata is available.

Note: in production, at fujitsu, memory should be onlined before cpu
      and our server didn't have any memory-less nodes and had no problems.

      But recent changes in MEM_GOING_ONLINE+page_cgroup
      will access not initialized zonelist of node.
      Anyway, there are memory-less node and we need some care.

Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
---
 mm/memory_hotplug.c |    6 ++++++
 1 file changed, 6 insertions(+)

Index: linux-3.0-rc1/mm/memory_hotplug.c
===================================================================
--- linux-3.0-rc1.orig/mm/memory_hotplug.c
+++ linux-3.0-rc1/mm/memory_hotplug.c
@@ -494,6 +494,12 @@ static pg_data_t __ref *hotadd_new_pgdat
 	/* init node's zones as empty zones, we don't have any present pages.*/
 	free_area_init_node(nid, zones_size, start_pfn, zholes_size);
 
+	/*
+	 * The node we allocated has no zone fallback lists. For avoiding
+	 * to access not-initialized zonelist, build here.
+	 */
+	build_all_zonelists(NULL);
+
 	return pgdat;
 }
 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/