linux-kernel - Re: [PATCH v4 6/6] GPIO: pca953x.c: Add missing irq_mask_ack handler in struct irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110608170139.GH8499@ponder.secretlab.ca>
Date:	Wed, 8 Jun 2011 11:01:39 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	David Jander <david@...tonic.nl>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 6/6] GPIO: pca953x.c: Add missing irq_mask_ack handler
 in struct irq_chip

On Wed, Jun 08, 2011 at 02:48:34PM +0200, David Jander wrote:
> Either .irq_mask_ack or .irq_ack need to be filled in, otherwise in
> kernel/irq/chip.c: mask_ack_irq() a non-initialized handler is called.
> 
> Signed-off-by: David Jander <david@...tonic.nl>

Does this matter anymore given that the driver no longer sets a handler?

g.

> ---
>  drivers/gpio/pca953x.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
> index dfed81f..b476c1c 100644
> --- a/drivers/gpio/pca953x.c
> +++ b/drivers/gpio/pca953x.c
> @@ -379,6 +379,7 @@ static int pca953x_irq_set_type(struct irq_data *d, unsigned int type)
>  static struct irq_chip pca953x_irq_chip = {
>  	.name			= "pca953x",
>  	.irq_mask		= pca953x_irq_mask,
> +	.irq_mask_ack		= pca953x_irq_mask,
>  	.irq_unmask		= pca953x_irq_unmask,
>  	.irq_bus_lock		= pca953x_irq_bus_lock,
>  	.irq_bus_sync_unlock	= pca953x_irq_bus_sync_unlock,
> -- 
> 1.7.4.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/