linux-kernel - Re: [PATCH v4 5/6] GPIO: pca953x.c: Fix warning of enabled interrupts in handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110608173253.GM8499@ponder.secretlab.ca>
Date:	Wed, 8 Jun 2011 11:32:53 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	David Jander <david@...tonic.nl>
Cc:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 5/6] GPIO: pca953x.c: Fix warning of enabled
 interrupts in handler

On Wed, Jun 08, 2011 at 02:48:33PM +0200, David Jander wrote:
> When using nested threaded irqs, use handle_nested_irq(). This function
> does not call the chip handler, so no handler is set.
> 
> Signed-off-by: David Jander <david@...tonic.nl>

Merged, thanks.

g.

> ---
>  drivers/gpio/pca953x.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/pca953x.c b/drivers/gpio/pca953x.c
> index 97e0d32..dfed81f 100644
> --- a/drivers/gpio/pca953x.c
> +++ b/drivers/gpio/pca953x.c
> @@ -436,7 +436,7 @@ static irqreturn_t pca953x_irq_handler(int irq, void *devid)
>  
>  	do {
>  		level = __ffs(pending);
> -		generic_handle_irq(level + chip->irq_base);
> +		handle_nested_irq(level + chip->irq_base);
>  
>  		pending &= ~(1 << level);
>  	} while (pending);
> @@ -484,8 +484,8 @@ static int pca953x_irq_setup(struct pca953x_chip *chip,
>  
>  			irq_clear_status_flags(irq, IRQ_NOREQUEST);
>  			irq_set_chip_data(irq, chip);
> -			irq_set_chip_and_handler(irq, &pca953x_irq_chip,
> -						 handle_simple_irq);
> +			irq_set_chip(irq, &pca953x_irq_chip);
> +			irq_set_nested_thread(irq, true);
>  #ifdef CONFIG_ARM
>  			set_irq_flags(irq, IRQF_VALID);
>  #else
> -- 
> 1.7.4.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/