linux-kernel - Re: [PATCH 2/2 v2] ramoops: add new line to each print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 08 Jun 2011 21:24:38 +0200
From:	Marco Stornelli <marco.stornelli@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	xiyou.wangcong@...il.com, stevie.trujillo@...il.com,
	kyungmin.park@...sung.com
Subject: Re: [PATCH 2/2 v2] ramoops: add new line to each print

Il 08/06/2011 21:27, Joe Perches ha scritto:
> On Wed, 2011-06-08 at 21:07 +0200, Marco Stornelli wrote:
>> From: Marco Stornelli<marco.stornelli@...il.com>
>> Add new line to each print.
>> diff --git a/drivers/char/ramoops.c b/drivers/char/ramoops.c
> []
>> @@ -186,6 +188,8 @@ static int __init ramoops_init(void)
>>   		 * if we didn't find a platform device, we use module parameters
>>   		 * building platform data on the fly.
>>   		 */
>> +		pr_info("platform device not found, "
>> +			"using module parameters\n");
>
> Thanks Marco, I think that looks better.
>
> Trivia:
>
> This fits on a single line and it's not generally a
> good thing to split a format across multiple lines.
>
> cheers, Joe

Mmmm...my editor said 81 cols, so I split the message into two lines. 
I'll check it again.

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/