linux-kernel - Re: [PATCH tip/core/rcu 18/28] jbd2,rcu: Convert call_rcu(free_devcache) to kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110608193431.GI5361@quack.suse.cz>
Date:	Wed, 8 Jun 2011 21:34:31 +0200
From:	Jan Kara <jack@...e.cz>
To:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, laijs@...fujitsu.com,
	dipankar@...ibm.com, akpm@...ux-foundation.org,
	mathieu.desnoyers@...ymtl.ca, josh@...htriplett.org,
	niv@...ibm.com, tglx@...utronix.de, peterz@...radead.org,
	rostedt@...dmis.org, Valdis.Kletnieks@...edu, dhowells@...hat.com,
	eric.dumazet@...il.com, darren@...art.com, patches@...aro.org,
	Jan Kara <jack@...e.cz>
Subject: Re: [PATCH tip/core/rcu 18/28] jbd2,rcu: Convert
 call_rcu(free_devcache) to kfree_rcu()

On Wed 08-06-11 12:29:57, Paul E. McKenney wrote:
> From: Lai Jiangshan <laijs@...fujitsu.com>
> 
> The rcu callback free_devcache() just calls a kfree(),
> so we use kfree_rcu() instead of the call_rcu(free_devcache).
> 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> Signed-off-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Jan Kara <jack@...e.cz>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>
  Acked-by: Jan Kara <jack@...e.cz>

								Honza
> ---
>  fs/jbd2/journal.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index e0ec3db..13fb464 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -2390,11 +2390,6 @@ struct devname_cache {
>  static struct devname_cache *devcache[1 << CACHE_SIZE_BITS];
>  static DEFINE_SPINLOCK(devname_cache_lock);
>  
> -static void free_devcache(struct rcu_head *rcu)
> -{
> -	kfree(rcu);
> -}
> -
>  const char *jbd2_dev_to_name(dev_t device)
>  {
>  	int	i = hash_32(device, CACHE_SIZE_BITS);
> @@ -2423,7 +2418,7 @@ const char *jbd2_dev_to_name(dev_t device)
>  			spin_unlock(&devname_cache_lock);
>  			return ret;
>  		}
> -		call_rcu(&devcache[i]->rcu, free_devcache);
> +		kfree_rcu(devcache[i], rcu);
>  	}
>  	devcache[i] = new_dev;
>  	devcache[i]->device = device;
> -- 
> 1.7.3.2
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/