linux-kernel - Re: [PATCH] checkpatch: Validate signature styles and To: and Cc: lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1307565647.16453.18.camel@Joe-Laptop>
Date:	Wed, 08 Jun 2011 13:40:47 -0700
From:	Joe Perches <joe@...ches.com>
To:	Nick Bowler <nbowler@...iptictech.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	anish singh <anish198519851985@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] checkpatch: Validate signature styles and To: and Cc:
 lines

On Wed, 2011-06-08 at 16:24 -0400, Nick Bowler wrote:
> On 2011-06-08 12:34 -0700, Joe Perches wrote:
> > Signatures have many forms and can sometimes cause problems
> > if not in the correct format when using git send-email or quilt.
> > Try to verify the signature tags and email addresses to use
> > the generally accepted "Signed-off-by: Full Name <email@...ain.tld>"
> > form.
> [...]
> > +			my $suggested_email = format_email(parse_email($email));
> > +			if ($suggested_email eq "") {
> > +				ERROR("email address '$email' is unrecognizable\n" . $herecurr);
> > +			} elsif ($suggested_email ne $email) {
> > +				WARN("email address '$email' might be better as '$suggested_email'\n" . $herecurr);
> If you're going to make suggestions, you should at the very least ensure
> that the suggestions are actually valid email addresses.  Otherwise,
> this script will suggest replacing valid addresses with invalid ones!

Anyone that puts angle brackets in a quoted name
is pretty silly.  There aren't any in git history.

What I did is pretty simple and covers most all
normally used cases.

You are free to improve email parsing.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/