linux-kernel - Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor management driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DF002BB.1020705@freescale.com>
Date:	Wed, 8 Jun 2011 18:16:11 -0500
From:	Timur Tabi <timur@...escale.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
CC:	<alan@...rguk.ukuu.org.uk>, <arnd@...db.de>,
	<kumar.gala@...escale.com>, <benh@...nel.crashing.org>,
	<greg@...ah.com>, <akpm@...nel.org>, <cmetcalf@...era.com>,
	<konrad.wilk@...cle.com>, <dsaxena@...aro.org>,
	<linuxppc-dev@...ts.ozlabs.org>, <linux-kernel@...r.kernel.org>,
	<linux-console@...r.kernel.org>
Subject: Re: [PATCH 7/7] [v4] drivers/virt: introduce Freescale hypervisor
 management driver

Randy Dunlap wrote:
>> Add the drivers/virt directory, which houses drivers that support
>> > virtualization environments, and add the Freescale hypervisor management
>> > driver.

> It can't go in linux/virt or linux/virt/fsl instead?  why drivers/ ?
> 
> or maybe linux/virt should be drivers/virt ?

I knew this would happen.  The reason I put it in drivers/virt is because Arnd
told me to put it there.  At this point, I don't give a damn where it goes, but
I wish you all would come to a consensus.

>> > + * ALTERNATIVELY, this software may be distributed under the terms of the
>> > + * GNU General Public License ("GPL") as published by the Free Software
>> > + * Foundation, either version 2 of that License or (at your option) any
>> > + * later version.

> Why any later version?  I thought that <powers> decided that Linux
> is GPL v2.

Um, you do realize that this isn't the only file in the kernel that is
v2-or-later?  Try this command on the Linux source, and you'll see what I mean:

grep -r "\(at your option\)" *

I'm dual-licensing the header file because it's meant for applications as well
as the kernel.  That way, no one needs to worry whether #including the header
file in his application will taint the app with the GPL.

>> > +/**
>> > + * struct fsl_hv_ioctl_restart: restart a partition
> This syntax should be (for all structs here):
> 
>  * struct fsl_hv_ioctl_restart - restart a partition
> 
> but the struct fields/members do use ':' instead of '-'.
> 
> Darn, I checked Documentation/kernel-doc-nano-HOWTO.txt and it says
> that ':' is optional but '-' is needed, so you could use
> 
>  * struct fsl_hv_ioctl_restart: - restart a partition
> 

Ok, I'll change it.

>> > + * fsl_hv_event_register -- register a callback for failover events

> Documentation/kernel-doc-nano-HOWTO.txt says to use one '-' here, not 2.

Ok.  I'll review that document and make sure my comments conform.  I guess I
just wasn't paying attention at the time.

-- 
Timur Tabi
Linux kernel developer at Freescale

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/