linux-kernel - Re: [patch 0/8] mm: memcg naturalization -rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110609084300.GD11603@cmpxchg.org>
Date:	Thu, 9 Jun 2011 10:43:00 +0200
From:	Johannes Weiner <hannes@...xchg.org>
To:	Rik van Riel <riel@...hat.com>
Cc:	Hiroyuki Kamezawa <kamezawa.hiroyuki@...il.com>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Daisuke Nishimura <nishimura@....nes.nec.co.jp>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Ying Han <yinghan@...gle.com>, Michal Hocko <mhocko@...e.cz>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Minchan Kim <minchan.kim@...il.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Mel Gorman <mgorman@...e.de>, Greg Thelen <gthelen@...gle.com>,
	Michel Lespinasse <walken@...gle.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [patch 0/8] mm: memcg naturalization -rc2

On Wed, Jun 08, 2011 at 09:15:46PM -0400, Rik van Riel wrote:
> On 06/02/2011 08:59 AM, Hiroyuki Kamezawa wrote:
> 
> >It seems your current series is a mixture of 2 works as
> >"re-desgin of softlimit" and "removal of global LRU".
> >I don't understand why you need 2 works at once.
> 
> That seems pretty obvious.
> 
> With the global LRU gone, the only way to reclaim
> pages in a global fashion (because the zone is low
> on memory), is to reclaim from all the memcgs in
> the zone.

That is correct.

> Doing that requires that the softlimit stuff is
> changed, and not only the biggest offender is
> attacked.

I think it's much more natural to do it that way, but it's not a
requirement as such.  We could just keep the extra soft limit reclaim
invocation in kswapd that looks for the biggest offender and the
hierarchy below it, then does a direct call to do_shrink_zone() to
bypass the generic hierarchy walk.

It's not very nice to have that kind of code duplication, but it's
possible to leave it like that for now.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/