linux-kernel - Re: [PATCH] uv/x2apic: update for change in pci bridge handling.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Jun 2011 20:32:49 +1000
From:	Dave Airlie <airlied@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Dave Airlie <airlied@...il.com>, jbarnes@...tuousgeek.org,
	linux-kernel@...r.kernel.org, steiner@....com
Subject: Re: [PATCH] uv/x2apic: update for change in pci bridge handling.

On Thu, 2011-06-09 at 09:09 +0200, Ingo Molnar wrote:
> * Dave Airlie <airlied@...il.com> wrote:
> 
> > On Wed, May 25, 2011 at 2:00 PM, Dave Airlie <airlied@...il.com> wrote:
> > > From: Dave Airlie <airlied@...hat.com>
> > >
> > > I forgot about the special uv handling code for this, so this
> > > patch fixes it up.
> > 
> > ping?
> > 
> > This fixes a warning and bug in Linus tree,
> > 
> >   CC      arch/x86/kernel/apic/x2apic_uv_x.o
> > /home/airlied/git/linux-2.6/arch/x86/kernel/apic/x2apic_uv_x.c: In
> > function ‘uv_system_init’:
> > /home/airlied/git/linux-2.6/arch/x86/kernel/apic/x2apic_uv_x.c:882:2:
> > warning: passing argument 1 of ‘pci_register_set_vga_state’ from
> > incompatible pointer type [enabled by default]
> > /home/airlied/git/linux-2.6/include/linux/pci.h:1094:13: note:
> > expected ‘arch_set_vga_state_t’ but argument is of type ‘int
> > (*)(struct pci_dev *, bool,  unsigned int,  bool)’
> > 
> > 
> > Dave.
> > 
> > >
> > > Signed-off-by: Dave Airlie <airlied@...hat.com>
> > > ---
> > >  arch/x86/kernel/apic/x2apic_uv_x.c |    8 ++++----
> > >  drivers/pci/pci.c                  |    4 ++--
> > >  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> Bug introduced via the DRM tree? Then the fix should go via the DRM 
> tree or via the PCI tree i suspect.

So I can take that as an ack for the x86 bit? :-)

I don't mind pushing it, just didn't want to step outside my box

Dave.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/