linux-kernel - Re: [PATCH 0/3] Support for SUSPEND and RESUME for USB chargers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 9 Jun 2011 14:25:46 +0300
From:	Heikki Krogerus <krohei@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	Anton Vorontsov <cbouatmailru@...il.com>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Grazvydas Ignotas <notasas@...il.com>
Subject: Re: [PATCH 0/3] Support for SUSPEND and RESUME for USB chargers

On Wed, Jun 08, 2011 at 01:54:05PM -0700, Greg KH wrote:
> On Wed, Jun 08, 2011 at 12:44:38PM +0300, Heikki Krogerus wrote:
> > The charging should be prevented if the bus is suspended.
> > 
> > These notifications will come from the udc drivers. I'll create a
> > separate patch set for those, as I guess the maintainers of the
> > controller drivers need to approve those.
> 
> Can you send them here as well?  These patches never set this value, so
> I don't see why you did it this way, instead of just getting the
> "normal" suspend/resume callback and triggering off of that.

I'm not completely sure what you mean with "normal" suspend/resume
callback? I want to get the information about the SUSPEND and RESUME
bus states to the charger drivers and I don't want to tie them with
any USB transceiver or controller driver. Wasn't this the reason for
having the otg notifiers in the first place?

I'll spend a bit more time with these and resend when I have
everything ready. Gražvydas noticed an issue with the
isp1704_charger.c so that patch is broken in any case.

> Still confused,

I did not think this through. Sorry about that. I should have send
everything from the beginning and I should have been more clear what
I'm after with these.

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/