lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Thu, 9 Jun 2011 17:10:55 +0530
From:	Prashant Shah <pshah.mumbai@...il.com>
To:	Ian Abbott <abbotti@....co.uk>
Cc:	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Frank Mori Hess <fmhess@...rs.sourceforge.net>,
	Ian Abbott <ian.abbott@....co.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] Staging: comedi: add dyna_pci10xx driver

Hi Ian,

On Thu, Jun 9, 2011 at 4:34 PM, Ian Abbott <abbotti@....co.uk> wrote:
> On 09/06/11 10:24, Prashant P. Shah wrote:

> It looks mostly okay to me as long as you got the PCI device ID
> allocated by PLX (which they'll happily do for their customers if you
> tell them what product the chip is is part of), and didn't just pull it
> out of a hat!

I will forward that to the vendor...

> I have a few more specific comments on the code (not many!):
> Best regards,
> Ian.

fixed and sent patch for the same.

Regards.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ