linux-kernel - Re: [PATCH] unicore32: fix build error for find bitops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimWYjzxhQBH2A76D590KBfjKbguTA@mail.gmail.com>
Date:	Thu, 9 Jun 2011 23:05:10 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	GuanXuetao <gxt@...c.pku.edu.cn>
Cc:	arnd@...db.de, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, greg@...ah.com
Subject: Re: [PATCH] unicore32: fix build error for find bitops

2011/6/9 Akinobu Mita <akinobu.mita@...il.com>:
> 2011/6/9 GuanXuetao <gxt@...c.pku.edu.cn>:
>> From: Guan Xuetao <gxt@...c.pku.edu.cn>
>>
>> Remove the __uc32_ prefix in find bitops functions.
>> see commit <19de85ef574c3a2182e3ccad9581805052f14946>
>>  bitops: add #ifndef for each of find bitops
>>
>> Signed-off-by: Guan Xuetao <gxt@...c.pku.edu.cn>
>> Cc: Akinobu Mita <akinobu.mita@...il.com>
>> ---
>>  arch/unicore32/include/asm/bitops.h |    6 ------
>>  arch/unicore32/kernel/ksyms.c       |    4 ++--
>>  arch/unicore32/lib/findbit.S        |   14 ++++++++------
>>  3 files changed, 10 insertions(+), 14 deletions(-)
>>
>> diff --git a/arch/unicore32/include/asm/bitops.h b/arch/unicore32/include/asm/bitops.h
>> index 1628a63..a9653f0 100644
>> --- a/arch/unicore32/include/asm/bitops.h
>> +++ b/arch/unicore32/include/asm/bitops.h
>> @@ -13,12 +13,6 @@
>>  #ifndef __UNICORE_BITOPS_H__
>>  #define __UNICORE_BITOPS_H__
>>
>> -#define find_next_bit          __uc32_find_next_bit
>> -#define find_next_zero_bit     __uc32_find_next_zero_bit
>> -
>> -#define find_first_bit         __uc32_find_first_bit
>> -#define find_first_zero_bit    __uc32_find_first_zero_bit
>> -
>
> Is this patch really fix the build error?
>
> If these find_*_bit macros are removed, vmlinux will have multiple
> definisions of find_*_bit. Because lib/find_next_bit.c is built
> unconditionally after the commit 63e424c84429903c92a0f1e9654c31ccaf6694d0
> ("arch: remove CONFIG_GENERIC_FIND_{NEXT_BIT,BIT_LE,LAST_BIT}".

The attached patch hopefully fix the build error but it is untested
because I can't find crosstool for unicore32. So could you apply
this patch on top of your patch and check whether it fixes?

View attachment "0001-unicore32-fix-build-error-for-find-bitops.patch" of type "text/x-diff" (1695 bytes)