linux-kernel - Re: [PATCH] input: add driver for Bosch Sensortec's BMA150 accelerometer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110609173203.020d5017@lxorguk.ukuu.org.uk>
Date:	Thu, 9 Jun 2011 17:32:03 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Eric Andersson <eric.andersson@...xphere.com>
Cc:	dmitry.torokhov@...il.com, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org, zhengguang.guo@...ch-sensortec.com,
	stefan.nilsson@...xphere.com,
	Albert Zhang <xu.zhang@...ch-sensortec.com>
Subject: Re: [PATCH] input: add driver for Bosch Sensortec's BMA150
 accelerometer

> > What locks this SMBUS transaction against others
> True! I will look over the locking for the next version.

I have a suspicion the two drivers are distant relatives actually - the
bugs look similar !
> 
> > > +static int bma150_set_range(struct i2c_client *client, unsigned char range)
> > > +{
> > > +	int ret;
> > > +	unsigned char data;
> > > +
> > > +	if (range > BMA150_RANGE_8G)
> > > +		return -EINVAL;
> > 
> > This should be actual values not a register range
> It is an actual value. See chapter 3.1.2 in the BMA150 datasheet where the
> acceleration range values are defined.

It should specify the units and be in meaningful ones not register values
(I got moaned at for that in my submission too!)

> I will send an updated version of the driver once I've fixed it!

Cool - I really don't care btw which driver we end up with a mix of both,
I just need it to work on our platform too.

Dunno where Dmitry has gone - has he vanished ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/