linux-kernel - Re: [PATCH] gpio-ep93xx: convert to platform_driver and use basic_mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTim1_6LZ1u_p-uhf5dYQYuKTjSSqZQ@mail.gmail.com>
Date:	Thu, 9 Jun 2011 12:42:16 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	ARM Kernel <linux-arm-kernel@...ts.infradead.org>,
	Ryan Mallon <ryan@...ewatersys.com>
Subject: Re: [PATCH] gpio-ep93xx: convert to platform_driver and use
 basic_mmio_gpio library

On Thu, Jun 9, 2011 at 10:43 AM, H Hartley Sweeten
<hartleys@...ionengravers.com> wrote:
> On Wednesday, June 08, 2011 3:08 PM, Grant Likely wrote:
>>
>> Merged, thanks.
>
> Thanks.  I just noticed I left in a debug message I added when changing
> this to a platform_driver.
>
>>> +static int __init ep93xx_gpio_init(void)
>>> +{
>>> +    pr_info("%s\n", __func__);
>>> +    return platform_driver_register(&ep93xx_gpio_driver);
>>>  }
>
> That pr_info shouldn't be there.  It just adds noise.
>
> Would you prefer a full new patch or just an incremental patch to remove
> this line?  The patch is already in next-20110609.
>
> Thanks, sorry for the trouble

Neither.  I just fixed it up and pushed out a commit.

g.



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/