linux-kernel - Re: [PATCH] Bootgraph.pl bug fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1106101459570.22872@pobox.suse.cz>
Date:	Fri, 10 Jun 2011 15:00:38 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Andrew Murray <amurray@...data.com>
Cc:	linux-embedded@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andrew Murray <amurray@...-data.co.uk>,
	Arjan van de Ven <arjan@...radead.org>
Subject: Re: [PATCH] Bootgraph.pl bug fix

On Thu, 9 Jun 2011, Andrew Murray wrote:

> This patch removes the assumption of the bootgraph.pl script that the
> timing information reported by PRINTK_TIME will contain at least one
> entry with a time of less than 100 seconds.
> 
> Not all boards correctly reset the system timer and in many cases the
> inital times reported by PRINTK_TIME is high. When this occurs the
> bootchart.pl script fails to give any useful output.
> 
> This patch sets the $firsttime variable to the largest value expected
> by PRINTK_TIME
> 
> Signed-off-by: Andrew Murray <amurray@...-data.co.uk>
> ---
>  scripts/bootgraph.pl |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/bootgraph.pl b/scripts/bootgraph.pl
> index 12caa82..b78fca9 100644
> --- a/scripts/bootgraph.pl
> +++ b/scripts/bootgraph.pl
> @@ -44,7 +44,7 @@ my %end;
>  my %type;
>  my $done = 0;
>  my $maxtime = 0;
> -my $firsttime = 100;
> +my $firsttime = 99999;
>  my $count = 0;
>  my %pids;
>  my %pidctr;

Adding Arjan to CC. Arjan, if you are OK with the patch, I can take it 
through my tree with your Ack.

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/