linux-kernel - Re: [PATCH] gpio: basic_mmio: add missing include of spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110610144655.GA26900@ponder.secretlab.ca>
Date:	Fri, 10 Jun 2011 08:46:55 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Jamie Iles <jamie@...ieiles.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h

On Fri, Jun 10, 2011 at 01:48:05PM +0100, Jamie Iles wrote:
> On Fri, Jun 10, 2011 at 01:44:49PM +0100, Jamie Iles wrote:
> > include/linux/basic_mmio_gpio.h uses a spinlock_t without including any
> > of the spinlock headers resulting in this compiler warning.
> > 
> > include/linux/basic_mmio_gpio.h:51:2: error: expected specifier-qualifier-list before 'spinlock_t'
> > 
> > Explicitly include linux/spinlock_types.h to fix it.
> 
> Sorry, wrong patch.  Here's the correct one.
> 
> Jamie

Applied, thanks.

g.

> 
> 8<---
> 
> From cd6afb281b31596c175ea3ee1d44f0efea25250f Mon Sep 17 00:00:00 2001
> From: Jamie Iles <jamie@...ieiles.com>
> Date: Fri, 10 Jun 2011 13:41:44 +0100
> Subject: [PATCH] gpio: basic_mmio: add missing include of spinlock_types.h
> 
> include/linux/basic_mmio_gpio.h uses a spinlock_t without including any
> of the spinlock headers resulting in this compiler warning.
> 
> include/linux/basic_mmio_gpio.h:51:2: error: expected specifier-qualifier-list before 'spinlock_t'
> 
> Explicitly include linux/spinlock_types.h to fix it.
> 
> Cc: Grant Likely <grant.likely@...retlab.ca>
> Signed-off-by: Jamie Iles <jamie@...ieiles.com>
> ---
>  include/linux/basic_mmio_gpio.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/basic_mmio_gpio.h b/include/linux/basic_mmio_gpio.h
> index 1ae1271..98999cf 100644
> --- a/include/linux/basic_mmio_gpio.h
> +++ b/include/linux/basic_mmio_gpio.h
> @@ -16,6 +16,7 @@
>  #include <linux/gpio.h>
>  #include <linux/types.h>
>  #include <linux/compiler.h>
> +#include <linux/spinlock_types.h>
>  
>  struct bgpio_pdata {
>  	int base;
> -- 
> 1.7.4.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/