linux-kernel - Re: [PATCH] Documentation: update kmemleak architecture support info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Jun 2011 15:55:18 +0100
From:	Catalin Marinas <catalin.marinas@....com>
To:	Daniel Baluta <dbaluta@...acom.com>
Cc:	Maxin B John <maxin.john@...il.com>,
	"nux-doc@...r.kernel.org" <nux-doc@...r.kernel.org>,
	"rdunlap@...otime.net" <rdunlap@...otime.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Documentation: update kmemleak architecture support
 info

On Fri, Jun 10, 2011 at 08:18:50AM +0100, Daniel Baluta wrote:
> On 06/10/2011 10:09 AM, Maxin B John wrote:
> > -Kmemleak is supported on x86, arm, powerpc, sparc, sh, microblaze and tile.
> > +Kmemleak is supported on x86, arm, powerpc, sparc, sh, microblaze, tile,
> > +s390 and mips.Please check DEBUG_KMEMLEAK dependencies in lib/Kconfig.debug
> > +for supported platforms.
> The point of adding my generic comment was to remove direct
> references to supported platforms.
> 
> In this case your patch should remove the line specifying supported
> platforms (x86, arm, powerpc, etc) and only add the line pointing
> the reader to lib/Kconfig.debug.
> 
> When a new platform will be supported lib/Kconfig.debug will
> be surely modified, and the change will be consistent with
> information in kmemleak.txt.

I think Daniel's suggestion is better, we don't have to worry about
changing the documentation every time we add a new architecture.

In addition to that, I would say "supported architectures" rather than
platforms.

Thanks.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/