linux-kernel - Re: [PATCH]rcu: avoid unnecessary thread wakeup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110610163842.GB2230@linux.vnet.ibm.com>
Date:	Fri, 10 Jun 2011 09:38:42 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Shaohua Li <shaohua.li@...el.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>
Subject: Re: [PATCH]rcu: avoid unnecessary thread wakeup

On Fri, Jun 10, 2011 at 03:50:51PM +0800, Shaohua Li wrote:
> invoke_rcu_cpu_kthread could be called in the thread itself. In this case,
> we don't need call wakeup, which is just wasting CPU.
> 
> Signed-off-by: Shaohua Li <shaohua.li@...el.com>
> 
> diff --git a/kernel/rcutree.c b/kernel/rcutree.c
> index 89419ff..f9bd051 100644
> --- a/kernel/rcutree.c
> +++ b/kernel/rcutree.c
> @@ -1475,7 +1475,8 @@ static void invoke_rcu_cpu_kthread(void)
>  		local_irq_restore(flags);
>  		return;
>  	}
> -	wake_up_process(__this_cpu_read(rcu_cpu_kthread_task));
> +	if (current != __this_cpu_read(rcu_cpu_kthread_task))
> +		wake_up_process(__this_cpu_read(rcu_cpu_kthread_task));
>  	local_irq_restore(flags);
>  }

Excellent point, thank you!

But how about combining the tests, perhaps something like the
following?

Unless you have objections or spot problems with it (or it breaks during
testing), I will queue the patch below with your SOB, since I derived
it from your patch.

							Thanx, Paul

------------------------------------------------------------------------

diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index b4b254d..eda3986 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -1523,11 +1523,9 @@ static void invoke_rcu_cpu_kthread(void)
 
 	local_irq_save(flags);
 	__this_cpu_write(rcu_cpu_has_work, 1);
-	if (__this_cpu_read(rcu_cpu_kthread_task) == NULL) {
-		local_irq_restore(flags);
-		return;
-	}
-	wake_up_process(__this_cpu_read(rcu_cpu_kthread_task));
+	if (__this_cpu_read(rcu_cpu_kthread_task) != NULL &&
+	    current != __this_cpu_read(rcu_cpu_kthread_task))
+		wake_up_process(__this_cpu_read(rcu_cpu_kthread_task));
 	local_irq_restore(flags);
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/