linux-kernel - Re: [PATCH 02/10] MCE: save most severe error information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinGZt1=uWrTDaEuT+DM1X3h+u1mng@mail.gmail.com>
Date:	Fri, 10 Jun 2011 11:08:41 -0700
From:	Tony Luck <tony.luck@...el.com>
To:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>, Borislav Petkov <bp@...64.org>,
	linux-kernel@...r.kernel.org, "Huang, Ying" <ying.huang@...el.com>,
	Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH 02/10] MCE: save most severe error information

2011/6/10 Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>:
> Could you clarify why we have to use mces_seen after mce_end(), please?

In part 10 I add:
+       if (worst == MCE_AR_SEVERITY) {
+               mce_action_required(&m, msg, regs);
+               kill_it = 0;
+       }

Which happens after mce_end() ... and wants to access the struct mce that
we filled out for this processor.

But it is possible that we don't need it - your comments to later parts
of this patch series point out that better severity table entries could
cover the checks for ADDRV and MISCV being set, and make the
error immediately fatal, rather than leaving it until this late stage to
do so.

I think we only actually need to save the address from the mce structure.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/