linux-kernel - Re: [PATCH 8/9] x86/amd-iommu: Search for existind dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110610205226.GN23047@sequoia.sous-sol.org>
Date:	Fri, 10 Jun 2011 13:52:26 -0700
From:	Chris Wright <chrisw@...s-sol.org>
To:	Joerg Roedel <joerg.roedel@....com>
Cc:	iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/9] x86/amd-iommu: Search for existind dev_data before
 allocting a new one

* Joerg Roedel (joerg.roedel@....com) wrote:
> +static struct iommu_dev_data *search_dev_data(u16 devid)
> +{
> +     struct iommu_dev_data *dev_data;
> +     unsigned long flags;
> +
> +	spin_lock_irqsave(&dev_data_list_lock, flags);
> +	list_for_each_entry(dev_data, &dev_data_list, dev_data_list) {
> +		if (dev_data->devid == devid)

This devid match on a global list is not going to work in a multi-segment
machine.  I guess non-zero segment function would either not exist or go
through swiotlb since it's not supported by hw def'n, so only a concern
for the future (along with the other devid based lookup tables).

thanks,
-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/