lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jun 2011 11:50:28 +0800 From: Xiao Guangrong <xiaoguangrong@...fujitsu.com> To: Avi Kivity <avi@...hat.com> CC: Marcelo Tosatti <mtosatti@...hat.com>, LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org> Subject: Re: [PATCH 09/15] KVM: MMU: split kvm_mmu_free_page On 06/09/2011 03:07 PM, Avi Kivity wrote: > On 06/07/2011 04:03 PM, Xiao Guangrong wrote: >> Split kvm_mmu_free_page to kvm_mmu_free_lock_parts and >> kvm_mmu_free_unlock_parts >> >> One is used to free the parts which is under mmu lock and the other is >> used to free the parts which can allow be freed out of mmu lock >> >> It is used by later patch > > Suggest kvm_mmu_isolate_page() and kvm_mmu_free_page(). Plus a comment explaining things, unless someone can come up with a better name. > Good names, will fix. >> -static void kvm_mmu_free_page(struct kvm_mmu_page *sp) >> +static void kvm_mmu_free_lock_parts(struct kvm_mmu_page *sp) >> { >> ASSERT(is_empty_shadow_page(sp->spt)); >> hlist_del(&sp->hash_link); >> - list_del(&sp->link); >> - free_page((unsigned long)sp->spt); >> if (!sp->role.direct) >> free_page((unsigned long)sp->gfns); >> +} >> + >> +static void kvm_mmu_free_unlock_parts(struct kvm_mmu_page *sp) >> +{ >> + list_del(&sp->link); >> + free_page((unsigned long)sp->spt); >> kmem_cache_free(mmu_page_header_cache, sp); >> } > > The list_del() must be run under a lock, no? it can access kvm->arch.active_mmu_pages. > In prepare path, we have moved the sp from active_mmu_pages to invlaid_list. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists