[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.00.1106101526390.24646@chino.kir.corp.google.com>
Date: Fri, 10 Jun 2011 15:30:35 -0700 (PDT)
From: David Rientjes <rientjes@...gle.com>
To: Russell King - ARM Linux <linux@....linux.org.uk>
cc: Linus Torvalds <torvalds@...ux-foundation.org>,
Dmitry Eremin-Solenikov <dbaryshkov@...il.com>,
Andrew Morton <akpm@...ux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
tglx@...utronix.de, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, mel@....ul.ie,
kamezawa.hiroyu@...fujitsu.com, riel@...hat.com, pavel@....cz
Subject: Re: [PATCH] Make GFP_DMA allocations w/o ZONE_DMA emit a warning
instead of failing
On Fri, 10 Jun 2011, Russell King - ARM Linux wrote:
> So those platforms which don't have a DMA zone, don't have any problems
> with DMA, yet want to use the very same driver which does have a problem
> on ISA hardware have to also put up with a useless notification that
> their kernel might be broken?
>
> Are you offering to participate on other architectures mailing lists to
> answer all the resulting queries?
>
It all depends on the wording of the "warning", it should make it clear
that this is not always an error condition and only affects certain types
of hardware which the user may or may not have. If you have any
suggestions on how to alter "task (pid): attempted to allocate DMA memory
without DMA support -- enable CONFIG_ZONE_DMA if needed" to make that more
clear, be my guest. The alternative is that the ISA hardware cannot
handle the memory returned fails unexpectedly and randomly without any
clear indication of what the issue is. I think what would be worse is
time lost for someone to realize CONFIG_ZONE_DMA isn't enabled, and that
could be significant (and probably generate many bug reports on its own)
since it isn't immediately obvious without doing some debugging.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists