linux-kernel - Re: [PATCH RESEND]Remove a warning for drivers/edac/i82975x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110610050747.GA3643@gmail.com>
Date:	Fri, 10 Jun 2011 13:07:50 +0800
From:	Harry Wei <jiaweiwei.xiyou@...il.com>
To:	Connor Hansen <cmdkhh@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND]Remove a warning for drivers/edac/i82975x_edac.c

On Wed, Jun 08, 2011 at 11:17:21PM -0700, Connor Hansen wrote:
> 
> this is not what the code you are changing does.
> 
> the code is not assigned that value, its or'd with it.
> 
> a test would be more like.
> 
> #include <stdio.h>
> int main()
> {
>         unsigned long page;  //page
>         unsigned int b = 5;  //info->eap is u32 = unsigned int
>                                        // typedef unsigned int __u32;
>         page = (unsigned long) b;
>         page |= 0x10000000ul;
> 
>         printf("%lu\n",page);
> 
>         return 0;
> }
> 
> This produces no warning.
> $ gcc -g test.c && ./a.out
> 268435461
> $
> 
> 0x10000000
> 10000000000000000000000000000
> 5
> 00000000000000000000000000101
> 0x10000000 | 5 =
> 10000000000000000000000000101
> 268435461
> 
> I am green to kernel development so I will wait for someone with a bit
> more knowledge to
> chime in, or verify this warning.
> Connor

You are right, but it really has warnings yet.
My PC is also 32-bits.

Thanks
Harry Wei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/