linux-kernel - [PATCH] platform, compal: Fix mem leak in compal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1106111858490.23835@swampdragon.chaosbits.net>
Date:	Sat, 11 Jun 2011 19:02:42 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	platform-driver-x86@...r.kernel.org
cc:	linux-kernel@...r.kernel.org, Matthew Garrett <mjg@...hat.com>,
	Cezary Jackiewicz <cezary.jackiewicz@...il.com>,
	Lennart Poettering <mzxreary@...inter.de>
Subject: [PATCH] platform, compal: Fix mem leak in compal_probe()

We'll leak the memory allocated to 'data' in 
drivers/platform/x86/compal-laptop.c::compal_probe() if 
sysfs_create_group() doesn't return 0.
Fix the leak by freeing the memory in that case.

Signed-off-by: Jesper Juhl <jj@...osbits.net>
---
 compal-laptop.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

	Compile tested only.

diff --git a/drivers/platform/x86/compal-laptop.c b/drivers/platform/x86/compal-laptop.c
index 3f204fd..8877b83 100644
--- a/drivers/platform/x86/compal-laptop.c
+++ b/drivers/platform/x86/compal-laptop.c
@@ -1030,8 +1030,10 @@ static int __devinit compal_probe(struct platform_device *pdev)
 	initialize_fan_control_data(data);
 
 	err = sysfs_create_group(&pdev->dev.kobj, &compal_attribute_group);
-	if (err)
+	if (err) {
+		kfree(data);
 		return err;
+	}
 
 	data->hwmon_dev = hwmon_device_register(&pdev->dev);
 	if (IS_ERR(data->hwmon_dev)) {


-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/