linux-kernel - Re: [PATCH] ide-cd: signedness warning fix again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110611.150706.985438181862065028.davem@davemloft.net>
Date:	Sat, 11 Jun 2011 15:07:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	cmdkhh@...il.com
Cc:	bp@...en8.de, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ide-cd: signedness warning fix again

From: Connor Hansen <cmdkhh@...il.com>
Date: Wed,  1 Jun 2011 22:52:05 -0700

> One of the legit warnings 'make W=3 drivers/ide/ide-cd.c'
> generates is:
> drivers/ide/ide-cd.c: In function ide_cd_do_request
> drivers/ide/ide-cd.c:828:2: warning: conversion to int from \
> unsigned int may change the sign of the result
> drivers/ide/ide-cd.c:833:2: warning: conversion to int from \
> unsigned int may change the sign of the result
> 
> nsectors is declared int, should be unsigned int.
> 
> blk_rq-sectors() returns unsigned int, and ide_complete_rq
> expects unsigned int as well.  Fixes both warnings.
> 
> Signed-off-by: Connor Hansen <cmdkhh@...il.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/