linux-kernel - Re: [PATCH] dma/ep93xx_dma.c: local symbols should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110611054751.GA2651@acer>
Date:	Sat, 11 Jun 2011 08:47:51 +0300
From:	Mika Westerberg <mika.westerberg@....fi>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	dan.j.williams@...el.com, vinod.koul@...el.com
Subject: Re: [PATCH] dma/ep93xx_dma.c: local symbols should be static

On Fri, Jun 10, 2011 at 03:15:05PM -0700, H Hartley Sweeten wrote:
> The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver
> and should be marked static.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>

Acked-by: Mika Westerberg <mika.westerberg@....fi>

> Cc: Dan Williams <dan.j.williams@...el.com>
> Cc: Vinod Koul <vinod.koul@...el.com>
> 
> ---
> 
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index 0766c1e..5d7a49b 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
>   *
>   * Returns a valid DMA descriptor or %NULL in case of failure.
>   */
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
>  ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
>  			   dma_addr_t src, size_t len, unsigned long flags)
>  {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/