linux-kernel - chained irq handler problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTi=urdW0WBHcVbVzDwwLzupP_Vh2EA@mail.gmail.com>
Date:	Sun, 12 Jun 2011 20:53:46 +0200
From:	Manuel Lauss <manuel.lauss@...glemail.com>
To:	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: chained irq handler problems

Hello Thomas,

I've been struggling to get an external IRQ multiplexer to work with the
chained handler infrastructure, and I was wondering whether you could shed
some light on it:

The code below is the one that works: in the ->irq_startup callback it
installs a "traditional" irq handler for the multiplexer cascade, and
the handler then reads the external status register and dispatches all
pending external irqs at once.

Now, when I register the cascade handler with irq_set_chained_handler() and
remove the irq_startup callback the system is overrun with an irq storm from
the external mux, which starts when userspace is booting (i.e. after
"Freeing unused kernel memory: xx" appears), rendering it effectively dead.

My question is: what are the differences in interrupt handling between the
"traditional" handler and the cascade handler case?
I also noticed that the cascade irq (the muxer irq line to the cpu) is not
disabled when the interrupt is serviced. Is this by design?

Thank you!
        Manuel Lauss


static irqreturn_t db1300_csc_handler(int irq, void *dev_id)
{
        unsigned short bisr = __raw_readw(__bcsr_virt + BCSR_REG_INTSTAT);

        for ( ; bisr; bisr &= bisr - 1)
                generic_handle_irq(__cscfirst + __ffs(bisr));

        return IRQ_HANDLED;
}

// mask/unmask/maskack for external ints come here

static unsigned int db1300_csc_startup(struct irq_data *d)
{
        int retval = 0;

        mutex_lock(&__cscmtx);
        if ((++__cscusecnt) == 1)
                retval = request_irq(__cscirq, &db1300_csc_handler,
                                     IRQF_TRIGGER_HIGH, "csc", 0);
        mutex_unlock(&__cscmtx);

        db1300_csc_unmask(d);

        return retval;
}

static void db1300_csc_shutdown(struct irq_data *d)
{
        db1300_csc_mask(d);

        mutex_lock(&__cscmtx);
        if ((--__cscusecnt) == 0)
                free_irq(__cscirq, &db1300_csc_handler);
        mutex_unlock(&__cscmtx);
}

static struct irq_chip db1300_csc_irq_type = {
        [...]
        .irq_startup    = db1300_csc_startup,
        .irq_shutdown   = db1300_csc_shutdown,
};

// external int initialization:
[...]
        for (irq = first; irq <= last; irq++)
                irq_set_chip_and_handler_name(irq, &db1300_csc_irq_type,
                                         handle_level_irq, "level");
[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/