linux-kernel - Re: [PATCH 1/1] kernel/sched.c: Fix array initialization typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110613005122.GC12311@mail.gmail.com>
Date:	Sun, 12 Jun 2011 18:51:22 -0600
From:	Jean Sacren <sakiwit@...il.com>
To:	Andy Isaacson <adi@...apodia.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] kernel/sched.c: Fix array initialization typo

From: Andy Isaacson <adi@...apodia.org>
Date: Sun, 12 Jun 2011 16:09:01 -0700
>
> It is a standard C idiom for defining array contents.  If you write
> int x[] = {
>     1,
>     2,
>     3
> };
> 
> then when I add a fourth element to your array, I have to modify two
> lines, and the diff will say
> -    3
> +    3,
> +    4
>  };
> 
> whereas if you wrote "3," as the last line of the initializer, the diff
> would be one line long.

I don't know how to thank you for this. Apparently the patch is bogus.
> 
> Furthermore, spot the error in this diff:
> 
> @@ -3,4 +3,5 @@ char *x[] = {
>      "quick",
>      "brown",
>      "fox"
> +    "jumped"
>  };
> 
> HTH, HAND,
> -andy

-- 
Jean Sacren
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/