linux-kernel - Re: [PATCH 03/15] tracing: Add a free on close control mechanism for buffer_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110613101248.GC30962@elte.hu>
Date:	Mon, 13 Jun 2011 12:12:48 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Vaibhav Nagarnaik <vnagarnaik@...gle.com>,
	Ingo Molnar <mingo@...hat.com>,
	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 03/15] tracing: Add a free on close control mechanism for
 buffer_size_kb


* Steven Rostedt <rostedt@...dmis.org> wrote:

> +	switch (cmd) {
> +	case TRACE_RINGBUF_FREE_ON_CLOSE: {
> +		info->free_buffer_on_close = !!arg;
> +		ret = 0;
> +		break;
> +	}
>  	}

that doesn't look very tidy.

> @@ -3635,9 +3700,12 @@ static const struct file_operations tracing_pipe_fops = {
>  };
>  
>  static const struct file_operations tracing_entries_fops = {
> -	.open		= tracing_open_generic,
> +	.open		= tracing_entries_open,
>  	.read		= tracing_entries_read,
>  	.write		= tracing_entries_write,
> +	.unlocked_ioctl	= tracing_entries_ioctl,
> +	.compat_ioctl	= tracing_entries_ioctl,

i don't like it at all that you are adding to the ftrace ABI here. 
The *only* premise of the whole /debug/tracing/ muck was to allow it 
to be human-parseable and scripted - an ioctl is clearly outside that 
scope. Instead of increasing the mess in /debug/tracing/ we want 
clean tracing done via the perf ABI ...

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/