linux-kernel - Re: [PATCH 02/15] tracing: Use NUMA allocation for per-cpu ring buffer pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1307964526.9218.49.camel@gandalf.stny.rr.com>
Date:	Mon, 13 Jun 2011 07:28:46 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Vaibhav Nagarnaik <vnagarnaik@...gle.com>,
	Ingo Molnar <mingo@...hat.com>,
	Michael Rubin <mrubin@...gle.com>,
	David Sharp <dhsharp@...gle.com>
Subject: Re: [PATCH 02/15] tracing: Use NUMA allocation for per-cpu ring
 buffer pages

On Mon, 2011-06-13 at 12:09 +0200, Ingo Molnar wrote:
> * Steven Rostedt <rostedt@...dmis.org> wrote:
> 
> >  	for (i = 0; i < nr_pages; i++) {
> > +		struct page *page;
> >  		bpage = kzalloc_node(ALIGN(sizeof(*bpage), cache_line_size()),
> 
> missing separation between local variable definitions and the first C 
> statement.
> 
> Same mistake repeats elsewhere in the patch as well.
> 
> > +			page = alloc_pages_node(cpu_to_node(cpu), GFP_KERNEL,
> > +						0);
> 
> that linebreak is pointless.

Probably to keep the 80 char limit :-p


> 
> > +		info->spare = ring_buffer_alloc_read_page(info->tr->buffer,
> > +								info->cpu);
> 
> ditto.

I can fix these up.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/