linux-kernel - Re: [PATCH 5/5] staging/easycap: Fix bytesperline calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 13 Jun 2011 15:36:59 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Kirill Smelkov <kirr@....spb.ru>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	Tomas Winkler <tomas.winkler@...el.com>,
	Mike Thomas <rmthomas@...olus.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] staging/easycap: Fix bytesperline calculation

It warms my heart to see a beautiful commit message like that,
complete with diagrams.  :)

> 
> P.S. why at all we use those mask/shifts? Why not use bitfields?

Because this is crap code from the staging dir.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/