linux-kernel - Re: [PATCH] efifb: fix device unregister on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 13 Jun 2011 14:33:28 +0100
From:	Maxin B John <maxin.john@...il.com>
To:	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Cc:	Peter Jones <pjones@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] efifb: fix device unregister on error path

Hi,

On Mon, Jun 13, 2011 at 12:51 PM, Konstantin Khlebnikov
<khlebnikov@...nvz.org> wrote:
> Argument of platform_device_unregister() should be efifb_device, not efifb_driver.
> bug in v3.0-rc1-57-gbb8b266
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@...nvz.org>
> ---
>  drivers/video/efifb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/efifb.c b/drivers/video/efifb.c
> index 69c49df..784139a 100644
> --- a/drivers/video/efifb.c
> +++ b/drivers/video/efifb.c
> @@ -541,7 +541,7 @@ static int __init efifb_init(void)
>         */
>        ret = platform_driver_probe(&efifb_driver, efifb_probe);
>        if (ret) {
> -               platform_device_unregister(&efifb_driver);
> +               platform_device_unregister(&efifb_device);
>                return ret;
>        }

The same issue is present in this thread:

https://lkml.org/lkml/2011/6/12/34
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/