lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jun 2011 11:15:20 +0800 From: Xiao Guangrong <xiaoguangrong@...fujitsu.com> To: Avi Kivity <avi@...hat.com> CC: Marcelo Tosatti <mtosatti@...hat.com>, LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org> Subject: Re: [PATCH 09/15] KVM: MMU: split kvm_mmu_free_page On 06/12/2011 04:33 PM, Avi Kivity wrote: > On 06/10/2011 06:50 AM, Xiao Guangrong wrote: >> >> +static void kvm_mmu_free_unlock_parts(struct kvm_mmu_page *sp) >> >> +{ >> >> + list_del(&sp->link); >> >> + free_page((unsigned long)sp->spt); >> >> kmem_cache_free(mmu_page_header_cache, sp); >> >> } >> > >> > The list_del() must be run under a lock, no? it can access kvm->arch.active_mmu_pages. >> > >> >> In prepare path, we have moved the sp from active_mmu_pages to invlaid_list. > > It still needs to be accessed under a lock, no matter which list is used. > Actually, if we need to free page in RCU context, we unlink them from invalid_list firstly: if (atomic_read(&kvm->arch.reader_counter)) { ...... list_del_init(invalid_list); trace_kvm_mmu_delay_free_pages(sp); call_rcu(&sp->rcu, free_invalid_pages_rcu); return; } Then, global list is not used anymore. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists